Source: openafs
Version: 1.8.14-1
Usertags: pidof-without-procps
Dear maintainer(s) of openafs,
it appears that openafs uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of openafs
that use `pidof` at runtime;
* via the `Build-Depends:` field of openafs, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of openafs, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that openafs uses `pidof` due to the following
code snippets:
```
path: openafs_1.8.14-1/debian/openafs-client-precheck
exit 1
fi
if pidof /sbin/afsd || pidof /usr/sbin/afsd; then
echo "afsd is already running, continuing" >&2
do_nothing_env
path: openafs_1.8.14-1/debian/openafs-client.init
# openafs-client package put afsd in /sbin.
start_client() {
if pidof /sbin/afsd >/dev/null || pidof /usr/sbin/afsd >/dev/null ; then
echo "."
else
path: openafs_1.8.14-1/debian/openafs-client.init
echo -n " afsd"
fi
if pidof /usr/sbin/afsd >/dev/null || pidof /sbin/afsd >/dev/null ; then
afsd -shutdown
fi
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
