Source: pppconfig
Version: 2.3.30
Usertags: pidof-without-procps
Dear maintainer(s) of pppconfig,
it appears that pppconfig uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of pppconfig
that use `pidof` at runtime;
* via the `Build-Depends:` field of pppconfig, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of pppconfig, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that pppconfig uses `pidof` due to the following
code snippets:
```
path: pppconfig_2.3.30/pppconfig
gettext("Choose Modem Config Method"));
if (! $result) { # true $result means no.
if (!system("pidof", "pppd")) {
msgbox(gettext("Can\'t probe while pppd is running."));
goto MANUAL;
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
