Source: preload
Version: 0.6.4-5+b2
Usertags: pidof-without-procps

Dear maintainer(s) of preload,

it appears that preload uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of preload
  that use `pidof` at runtime;
* via the `Build-Depends:` field of preload, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of preload, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that preload uses `pidof` due to the following
code snippets:

```
path: preload_0.6.4-5/debian/patches/logrotate_619384
     postrotate
-       /bin/kill -HUP `/sbin/pidof preload 2>/dev/null` 2> /dev/null || true
+       /bin/kill -HUP `/bin/pidof preload 2>/dev/null` 2> /dev/null || true
     endscript
 }


path: preload_0.6.4-5/debian/patches/logrotate_619384
     compress
     postrotate
-       /bin/kill -HUP `/sbin/pidof preload 2>/dev/null` 2> /dev/null || true
+       /bin/kill -HUP `/bin/pidof preload 2>/dev/null` 2> /dev/null || true
     endscript


path: preload_0.6.4-5/preload.logrotate.in
    compress
    postrotate
        /bin/kill -HUP `/bin/pidof preload 2>/dev/null` 2> /dev/null || true
    endscript
}
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to