Source: rocksdb
Version: 9.11.2-1
Usertags: pidof-without-procps
Dear maintainer(s) of rocksdb,
it appears that rocksdb uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of rocksdb
that use `pidof` at runtime;
* via the `Build-Depends:` field of rocksdb, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of rocksdb, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that rocksdb uses `pidof` due to the following
code snippets:
```
path: rocksdb_9.11.2-1/tools/regression_test.sh
# $6 --- async_io. Default: False
function run_db_bench {
# Make sure no other db_bench is running. (Make sure command succeeds if pidof
# command exists but finds nothing.)
pids_cmd='pidof db_bench || pidof --version > /dev/null'
path: rocksdb_9.11.2-1/tools/regression_test.sh
# But first, make best effort to kill any db_bench that have run for more
# than 12 hours, as that indicates a hung or runaway process.
kill_old_cmd='for PID in $(pidof db_bench); do [ "$(($(stat -c %Y /proc/$PID)
+ 43200))" -lt "$(date +%s)" ] && echo "Killing old db_bench $PID" && kill $PID
&& sleep 5 && kill -9 $PID && sleep 5; done; pidof --version > /dev/null'
if ! [ -z "$REMOTE_USER_AT_HOST" ]; then
pids_cmd="$SSH $REMOTE_USER_AT_HOST '$pids_cmd'"
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
