Source: rocm-smi-lib
Version: 6.4.1-1.1
Usertags: pidof-without-procps

Dear maintainer(s) of rocm-smi-lib,

it appears that rocm-smi-lib uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of rocm-smi-lib
  that use `pidof` at runtime;
* via the `Build-Depends:` field of rocm-smi-lib, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of rocm-smi-lib, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that rocm-smi-lib uses `pidof` due to the following
code snippets:

```
path: rocm-smi-lib_6.4.1-1.1/python_smi_tools/rocm_smi.py
    :param name: Process name of a program to be parsed
    """
    return check_output(['pidof', name])
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to