Source: x2goserver
Version: 4.1.0.6-1.1+b1
Usertags: pidof-without-procps
Dear maintainer(s) of x2goserver,
it appears that x2goserver uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of x2goserver
that use `pidof` at runtime;
* via the `Build-Depends:` field of x2goserver, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of x2goserver, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that x2goserver uses `pidof` due to the following
code snippets:
```
path:
x2goserver_4.1.0.6-1.1/x2goserver-desktopsharing/bin/x2goterminate-desktopsharing
PIDOF='/usr/local/sbin/pidof'
elif [ -x '/usr/sbin/pidof' ]; then
PIDOF='/usr/sbin/pidof'
elif [ -x '/sbin/pidof' ]; then
PIDOF='/sbin/pidof'
path:
x2goserver_4.1.0.6-1.1/x2goserver-desktopsharing/bin/x2goterminate-desktopsharing
PIDOF='/sbin/pidof'
else
# no pidof utility found, get out the big hammer!!!
killall 'x2godesktopsharing'
exit '0'
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
