Source: xdg-utils
Version: 1.2.1-2
Usertags: pidof-without-procps

Dear maintainer(s) of xdg-utils,

it appears that xdg-utils uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of xdg-utils
  that use `pidof` at runtime;
* via the `Build-Depends:` field of xdg-utils, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of xdg-utils, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that xdg-utils uses `pidof` due to the following
code snippets:

```
path: xdg-utils_1.2.1-2/tests/include/desktop_environment
        xfce_version=`xfce4-session --version | grep '(Xfce ' | cut -d '(' -f 2 
| cut -d ' ' -f2 | cut -d ')' -f1`
        # From massonnet on FreeNode/#xfce
        #if [ `pidof xfce4-session` ]; then
        if [ "$GDMSESSION" = 'xfce4' ] ; then
                running="xfce $running"
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to