Source: xmonad-contrib Version: 0.18.1-1 Usertags: pidof-without-procps Dear maintainer(s) of xmonad-contrib,
it appears that xmonad-contrib uses `pidof` in its testsuite, or that at least one of its binary packages uses `pidof` at runtime. Historically, `pidof` was provided by the Essential package `sysvinit-tools`, making an explicit dependency unnecessary. However `pidof` will soon be moved to `procps` and will no longer be part of the Essential set. Please add an explicit dependency on `procps`: * via the `Depends:` field of all binary packages of xmonad-contrib that use `pidof` at runtime; * via the `Build-Depends:` field of xmonad-contrib, if `pidof` is used in tests run at build-time; * via the `Depends:` field of `debian/control/tests`, if `pidof` is used in autopkgtests. To prevent any disruption for users of xmonad-contrib, please add this dependency now, before `pidof` is moved from `sysvinit-utils` to `procps`. Alternatively, you could remove all uses of `pidof`. It is believed that xmonad-contrib uses `pidof` due to the following code snippets: ``` path: xmonad-contrib_0.18.1-1/XMonad/Prompt/RunOrRaise.hs isApp "firefox" = className =? "Firefox-bin" <||> className =? "Firefox" isApp "thunderbird" = className =? "Thunderbird-bin" <||> className =? "Thunderbird" isApp x = liftA2 (==) pid $ pidof x pidof :: String -> Query Int path: xmonad-contrib_0.18.1-1/XMonad/Prompt/RunOrRaise.hs pidof :: String -> Query Int pidof x = io $ (runProcessWithInput "pidof" [x] [] >>= readIO) `E.catch` econst 0 pid :: Query Int path: xmonad-contrib_0.18.1-1/XMonad/Prompt/RunOrRaise.hs isApp x = liftA2 (==) pid $ pidof x pidof :: String -> Query Int pidof x = io $ (runProcessWithInput "pidof" [x] [] >>= readIO) `E.catch` econst 0 ``` Feel free to close this issue if this is a false positive (for example if this code is in an unreachable code path). Regards, -- Gioele Barabucci
