Gioele Barabucci wrote... > it appears that ngircd uses `pidof` in its testsuite, or that > at least one of its binary packages uses `pidof` at runtime.
Well, yes and no.
The pidof.sh script is a wrapper to identify the pid of a process in a
platform-agnostic way. Using pidof(1) is just one of the several methods
tried, so a missing pidof should not affect the test suite execution
result (famous last words).
> Please add an explicit dependency on `procps`:
Currently, Build-Depends: procps already exists, making pidof.sh use the pgrep
program during build. But there is no such dependency in debian/tests/control
so in autopkgtest, pidof.sh currently falls back to pidof, and will in the
future try some ps and grep heuristics. Such a difference looks bad, and while
it didn't hurt in the past but might create situations hard to track down. Will
adjust accordingly, thanks for making me aware of that.
Two more things:
(...)
> * via the `Depends:` field of `debian/control/tests`, if `pidof` is
> used in autopkgtests.
Unless I've missed some changes, that's not the correct path to declare
dependencies for autopkgtest.
And second, while you announced a MBF in debian-devel, the ngircd
package was not in the list. Again, did I miss something?
Christoph
signature.asc
Description: PGP signature
