Source: tupi
Version: 0.2+git08-8
Severity: serious
Justification: ftbfs
Tags: ftbfs patch
Control: block 1138499 by -1

Dear Maintainer,

Your package fails to build from source with the new libquazip1 version 1.7.1, because it contains a patch that hard-codes version 1.5 in the build script. I have attached a patch that bumps it to target 1.7.1; I would advise you to try and find an alternative way to patch the source such that it does not target a specific version of QuaZip, so this does not happen with every future new version.

Regards
--
Ben Westover
diff --git a/debian/patches/fix_quazip_path.patch b/debian/patches/fix_quazip_path.patch
index 573e5b6..7500d31 100644
--- a/debian/patches/fix_quazip_path.patch
+++ b/debian/patches/fix_quazip_path.patch
@@ -13,7 +13,7 @@ Bug-Debian: https://bugs.debian.org/963386
  
  unix:!macx {
 -  INCLUDEPATH += /usr/include/quazip
-+  INCLUDEPATH += /usr/include/QuaZip-Qt5-1.5
++  INCLUDEPATH += /usr/include/QuaZip-Qt5-1.7.1
  }
  
  LIBS += -lz
@@ -24,7 +24,7 @@ Bug-Debian: https://bugs.debian.org/963386
  		</defines>
                  <includes>
 -                        <include path="/usr/include/quazip/" />
-+                        <include path="/usr/include/QuaZip-Qt5-1.5/" />
++                        <include path="/usr/include/QuaZip-Qt5-1.7.1/" />
                  </includes>
  	</provide>
  	<solution>
@@ -33,7 +33,7 @@ Bug-Debian: https://bugs.debian.org/963386
 @@ -1,5 +1,5 @@
  # Generated automatically at 2016-08-01 18:07:32 -0500! PLEASE DO NOT EDIT!
 -INCLUDEPATH += /usr/local/include /usr/include/libavformat/ /usr/include/libavcodec/ /usr/include/quazip/
-+INCLUDEPATH += /usr/local/include /usr/include/libavformat/ /usr/include/libavcodec/ /usr/include/QuaZip-Qt5-1.5/
++INCLUDEPATH += /usr/local/include /usr/include/libavformat/ /usr/include/libavcodec/ /usr/include/QuaZip-Qt5-1.7.1/
  LIBS += -L/usr/local/lib -lavformat -lavcodec -lquazip -lz -ltheora -ltheoraenc -ltheoradec -logg -ltupifwgui -ltupifwcore
  QT += opengl core gui svg xml network
  DEFINES += HAVE_LIBAV HAVE_QUAZIP HAVE_ZLIB HAVE_MULTIMEDIA HAVE_THEORA K_NODEBUG VERSION=\\\"0.2\\\" CODE_NAME=\\\"Beraba\\\" REVISION=\\\"git08\\\" CONFIG_VERSION=\\\"2\\\"

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to