Xiyue Deng <[email protected]> writes: > Sean Whitton <[email protected]> writes: > >> Xiyue Deng [11/Jun 7:13pm -07] wrote: >>> Hi Sean, >>> >>> Sean Whitton <[email protected]> writes: >>> >>>> Xiyue Deng [10/Jun 11:23pm -07] wrote: >>>>> So I guess this can really work! >>>> >>>> Nice. >>>> >>>>> Will continue with this after the integration test is merged so that >>>>> we have some test coverage. >>>> >>>> IMO this is more important than that other work and can merge first. >>> >>> Ah I was hoping that the test branch is safer as it doesn't change any >>> functions and can go in first. >>> >>> Anyway, I experimented a change[1] and tested it in the >>> `built-in-addon-handling' branch, and rebased it on to the test branch >>> for testing. One of the test cases has cl-lib in Package-Requires, and >>> the generated diff looked OK[2]. >>> >>> So now we only remove `emacs' from the list of dependencies. The code >>> can be further simplified, but I'd like to keep the current structure in >>> case we want to do more later. >> >> I think I'd prefer to strip out everything we don't need anymore -- it's >> always there in the Git history if required again. > > Ack. Now I only keep the comparison with "emacs". Also shortened the doc > string. PTAL.
Friendly ping. -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
