On Mon, Jul 13, 2026 at 5:32 AM Trupti <[email protected]> wrote: > > On 2026-07-03 15:23, Jeffrey Walton wrote: > > Hi Trupti, > > > > On Fri, Jul 3, 2026 at 4:17 AM Trupti <[email protected]> wrote: > >> > >> Hi JeffHi Jeff, > > > > One small suggestion for the patch. For: > > > > private: > > static ivec set_vector(int i) > > { > > #ifdef __GNUC__ > > - return (ivec){i, i, i, i}; > > + return (ivec){(unsigned int)i,(unsigned int)i, (unsigned > > int)i, (unsigned int)i}; > > #else > > #error compiler not supported > > #endif > > > > I believe you can use this, which usually produces faster code. I'm > > not sure how important it is since a C++ constructor is probably _not_ > > being called on a critical path. > > > > + return (ivec)vec_splat_s32(i); > > > > There's also a vec_splat_u32 for unsigned integers. But the cast > > before the return should handle the type conversion from int to > > unsigned int vector. > > Thank you for pointing it out. > I tried return (ivec)vec_splat_s32(i); but it gave: > error: argument 1 must be a literal between -16 and 15, inclusive > since it requires a compile-time constant, but i here is a runtime > value. > > So I used vec_splats((unsigned int)i) instead, and opened a Merge > Request with the updated patch: > with the updated patch > https://salsa.debian.org/multimedia-team/supercollider-sc3-plugins/-/merge_requests/4
My bad. Sorry about the extra noise! Jeff
