This is an automated message from the Debian DFSG, Licensing & New
Packages Team.
The Debian NEW review of node-cssfilter 0.0.11-1 has been completed.
Decision: ACCEPTED
Reviewer: Andrew McMillan
Review comment:
Hi,
Some pedantic issues found during the review. I'm not sure if the first one is
an actual problem, or a misdiagnosis. Similarly with the third, and the second
is very minor.
1. Installed package has no Node.js entry point, so `require('cssfilter')` fails
- Files: `debian/node-cssfilter.install`, `package.json`, `test/test_css.js`,
`debian/tests/pkg-js/test`
- Evidence: `debian/node-cssfilter.install` contains `dist
usr/share/nodejs/cssfilter`; package.json has `"main": "lib/index.js"`; the
upstream tests start with `var filterCSS = require('../');` and
`require('../lib/parser')`; `debian/tests/pkg-js/test` runs `mocha -t 5000 -R
spec`.
- Problem: Installing only dist/ puts a browserify UMD bundle (whose top-level
IIFE never assigns `module.exports`) and its minified copy into
/usr/share/nodejs/cssfilter/, with no package.json and no lib/. Debian Node.js
resolves `require('cssfilter')` to /usr/share/nodejs/cssfilter/ and needs a
package.json "main" (=> lib/index.js) or an index.js there, neither of which is
installed, so the module is not loadable by any Node consumer
— the package's only purpose. The pkg-js autopkgtest compounds this: its tests
use source-tree-relative requires and `mocha`/`node-should` are only listed in
Build-Depends-Indep with no `debian/tests/control` (or
`debian/tests/pkg-js/control`) declaring them as test Depends, so the test
cannot run against the installed package.
- Fix: Install the loadable module (e.g. `lib usr/share/nodejs/cssfilter` plus
package.json) in `debian/node-cssfilter.install`, moving the browser bundle (if
wanted at all) to /usr/share/javascript or similar, and declare the test
dependencies via `debian/tests/control` (`Depends: node-mocha, node-should`) so
the autopkgtest
2. Standards-Version 4.7.4 predates the current policy
- Files: `debian/control`
- Evidence: `Standards-Version: 4.7.4`; current Debian Policy is 4.7.4.1
(2026-03-31).
- Problem: A brand-new package should declare the current Standards-Version
(Policy §4.1).
- Fix: Bump to 4.7.4.1 after checking the A10.2 upgrading-checklist entry for
anything affecting the package.
3. uscan finds only upstream versions older than the packaged one
- Files: `debian/watch`
- Evidence: upstream `0.0.10`, packaged `0.0.11`
- Problem: The newest version uscan finds with `debian/watch` is older than
the version in `debian/changelog`, so the watch file does not find the packaged
release: it may look in the wrong place, or the versions may need mangling to
compare.
- Fix: Check where `debian/watch` looks and how it mangles versions.
Thanks!
Full review details: https://dfsg-new-queue.debian.org/reviews/node-cssfilter
