On Sat, 2026-10-17 at 09:37 +0100, Edward Betts wrote: > Hi Andrew, > > Thanks for the review! > > On 2026-10-12 10:31, [email protected] wrote: > > 1. Installed package has no Node.js entry point, so > > `require('cssfilter')` fails > > ... > > the test cannot run against the installed package. > > - Fix: Install the loadable module (e.g. `lib > > usr/share/nodejs/cssfilter` plus package.json) in > > `debian/node-cssfilter.install`, moving the browser bundle (if > > wanted > > at all) to /usr/share/javascript or similar, and declare the test > > dependencies via `debian/tests/control` (`Depends: node-mocha, > > node-should`) so the autopkgtest > > I'm confused. The package includes package.json and autopkgtest test > works, it picks up the test dependencies from Build-Depends-Indep. > The pkg-js runner creates a temporary directory, links lib/ and > package.json from /usr/share/nodejs/cssfilter, and copies only the > tests from the source tree into it.
The LLM is really keen on explaining why the tests don't happen, but I think the process of triggering the tests happens in a lot of sneaky ways in Debian, with (inevitably) lots of language-specific stuff that it doesn't understand. I'm working hard to tune down these false positives, but ultimately the only way to do this right will be to do an actual clean-room build on upload. I'll get to that in due course, but until I can do that we'll get this kind of issue. Overall these reviews do seem to be catching some quite useful things, but the DFSG team are only using them as a guide, and verifying the findings that we believe are blockers (not the ones the LLM thinks are blockers either). > > > 2. Standards-Version 4.7.4 predates the current policy > > > > - Files: `debian/control` > > - Evidence: `Standards-Version: 4.7.4`; current Debian Policy is > > 4.7.4.1 (2026-03-31). > > - Problem: A brand-new package should declare the current > > Standards-Version (Policy §4.1). > > - Fix: Bump to 4.7.4.1 after checking the A10.2 upgrading- > > checklist > > entry for anything affecting the package. > > Thanks. I'll fix this. Don't. It's not needed - this is a finding that I have disabled now - the 4th digit is not needed. > > 3. uscan finds only upstream versions older than the packaged one > > > > - Files: `debian/watch` > > - Evidence: upstream `0.0.10`, packaged `0.0.11` > > - Problem: The newest version uscan finds with `debian/watch` is > > older > > than the version in `debian/changelog`, so the watch file does not > > find > > the packaged release: it may look in the wrong place, or the > > versions > > may need mangling to compare. > > - Fix: Check where `debian/watch` looks and how it mangles > > versions. > > Upstream forgot to tag `0.0.11`. > Thanks, Andrew. -- ---------------------------------------------------------------------- Porirua, New Zealand +64 (27) 288 6741 https://andrew.mcmillan.net.nz Facts do not cease to exist because they are ignored. -- Aldous Huxley, "Proper Studies", 1927 ----------------------------------------------------------------------
