This is an automated message from the Debian DFSG, Licensing & New
Packages Team.

The Debian NEW review of python-zmqtt 0.2.5-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

One minor issue noted in review...

Autopkgtest setup is not wired up: no debian/tests/control, autopkgtest never 
runs

 - Files: `debian/rules`, `debian/control`, `debian/tests/mosquitto-start.sh`, 
`debian/tests/mosquitto-stop.sh`
 - Evidence: debian/tests/ contains only mosquitto-start.sh and 
mosquitto-stop.sh; debian/rules comments say the 
`PYBUILD_BEFORE_TEST`/`AFTER_TEST` declaration "covers ... the 
autopkgtest-pkg-pybuild run", and Build-Depends-Indep carries `mosquitto 
<!nocheck>`/`mosquitto-clients <!nocheck>`. No `Tests:` entry is declared.
 - Problem: Policy ยง5.6.30: the `Testsuite:` field is added by dpkg only when a 
`debian/tests/control` file is present in the source package. Neither debhelper 
14 nor /usr/bin/dh_python3 (grep: no `Testsuite`/`autopkgtest` generation) adds 
one. So in the archive autopkgtest will not run the broker-based suite the 
maintainer built, and the <!nocheck> test dependencies and start/stop scripts 
serving it are dormant beyond the already-covered build-time `dh_auto_test` run.
 - Fix: Add `debian/tests/control` declaring the pybuild autopkgtest, e.g. 
`Tests: pybuild` with a `Depends:` on python3-all and the test packages, or (if 
only build-time testing is wanted) drop the autopkgtest-specific scaffolding 
and comments from debian/rules and Build-Depends-Indep.


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/python-zmqtt

Reply via email to