Hi Fab, - Why are the rust build-deps in d/control or'ed? It shouldn't need to be like that.
- Build-depend on cargo:native and rustc:native to allow cross- compilation to work. I tried to cross-compile from amd64 to arm64 (via sbuild --host=arm64) and the build failed. :native arch qualifier installs cargo and rustc for the target arch rather than the host arch as per deb-src-control(5) manpage. Consider using the output of `debcargo deb-dependencies Cargo.toml` verbatim in Build-Depends and everything except rustc/cargo/libstd-rust- dev in Depends, since it will set all of these correctly. (Make sure to apply patches before doing so to pick up on relaxed Cargo.toml.) - debhelper-compat = 14 means you don't need misc:Depends or shlibs:Depends in Depends, it will add them by itself according to debhelper-compat-upgrade-checklist(7) manpage. - Consider adding autopkgtests based on cargo-auto-test. You can see any rust-* package on sources.debian.org to see what debcargo generates and do something similar to test the package continues to build/compile. - Add a comment to the shell-script-fails-syntax-check lintian-override explaining why it is being overridden. Presumably it's because it's an upstream script that is never used, but then shouldn't this be excluded from the librust-*-dev package? - Why does d/watch specify Repack: yes when there is no files being excluded or repack happening? And git mode will anyways exhibit the same behaviour as it will use origtargz regardless. - d/watch has a weird "this is a version 4 file" comment, is this from the template? - Dversionmangle in d/watch is not a valid key. It's Dversion-Mangle. Also consider using "auto" value which is the same thing. - Gitmodules in d/watch is not a valid key. It's Git-Modules. Also there are no submodules from upstream so why is this set? - The binary should be installed to usr/bin/whatwg-html-build, not usr/bin/html-build. -- Maytham
signature.asc
Description: This is a digitally signed message part

