Hi Maytham,

(Identical to my previous message, but sent again because I missed CC-ing 
[email protected])

Thanks for the review.

Since I chose to rename the package to html-build (to conform to upstream's 
name), I created a new repo to start on fresh base:

        https://salsa.debian.org/bastif/html-build

You can still use the old one, which would permit you to see the recent changes.

By the way, this requires the version 0.40 of crate markup5ever_rcdom (package 
rust-markup5ever-rcdom). But it has not been uploaded to the archive yet.
That's because with v0.35 the autopkgtests failed (when mixed with html5ever 
0.40).
You can get the deb by using the repo which is on my debusine workspace [1]. 
The snipped for apt sources is displayed there.

[1] https://debusine.debian.net/debian/developers-bastif-czkawka/

All other comments are below.

Le samedi 14 novembre 2026 00:32:59 heure normale d’Europe centrale, vous avez 
écrit :
> Hi Fab,
> 
> - Why are the rust build-deps in d/control or'ed? It shouldn't need to
> be like that.

I thought it might be easier to maintain.

Jonas ([email protected]) which is not part of the rust team (but maintains numerous rust 
based packages) and doesn't follow the approach of the team, doesn't always use 
versioned rust dependencies for their packages.

I don't have a strong opinion, so did as you asked. With this, any update of 
html5ever (& related) crate will require to upload a new version of html-build 
having updated relaxed dependencies.

> - Build-depend on cargo:native and rustc:native to allow cross-
> compilation to work. I tried to cross-compile from amd64 to arm64 (via
> sbuild --host=arm64) and the build failed. :native arch qualifier
> installs cargo and rustc for the target arch rather than the host arch
> as per deb-src-control(5) manpage.

Done. but it still doesn't cross-build on salsa the pipeline (I didn't notice 
that cross build jobs aren't enabled anymore in the salsa pipeline). There is 
some other dependency issue apparently.

> Consider using the output of `debcargo deb-dependencies Cargo.toml`
> verbatim in Build-Depends and everything except rustc/cargo/libstd-rust-
> dev in Depends, since it will set all of these correctly. (Make sure to
> apply patches before doing so to pick up on relaxed Cargo.toml.)

Done

> - debhelper-compat = 14 means you don't need misc:Depends or
> shlibs:Depends in Depends, it will add them by itself according to
> debhelper-compat-upgrade-checklist(7) manpage.

Thanks, removed.

> - Consider adding autopkgtests based on cargo-auto-test. You can see any
> rust-* package on sources.debian.org to see what debcargo generates and
> do something similar to test the package continues to build/compile.

I discussed this shortly on #debian-rust. For binary crates, there are usually 
no autopkgtests. Moreover upstream doesn't have any integration test of the 
binary itself. It only has rust unit tests. These unit tests are already 
invoked by dh-cargo when the package is built.

I anyway created a librust-*-dev package which is however unlikely to be needed 
by any other rust package. So this is actually somehow only useful to run the 
autopkgtests. I was struggling at getting it work with cargo-auto-test but this 
is now fine. Using it however requires one to keep updating the package version 
if d/tests/control at every update.

> - Add a comment to the shell-script-fails-syntax-check lintian-override
> explaining why it is being overridden. Presumably it's because it's an
> upstream script that is never used, but then shouldn't this be excluded
> from the librust-*-dev package?

I excluded the file from librust-*-dev.

> - Why does d/watch specify Repack: yes when there is no files being
> excluded or repack happening? And git mode will anyways exhibit the same
> behaviour as it will use origtargz regardless.

I removed the "repacksuffix" earlier, but forgot removing "repack" as well.
It's now removed.

> - d/watch has a weird "this is a version 4 file" comment, is this from
> the template?

Very likely, I removed it. It was already there in the original d/watch that I 
migrated from v4 to v5

> - Dversionmangle in d/watch is not a valid key. It's Dversion-Mangle.
> Also consider using "auto" value which is the same thing.

According to manpage for "debian-watch": 
"Hyphens in key names are ignored. Matching-Pattern is equivalent to 
Matchingpattern"

So both keys are valid.

I set the value to "auto".

> - Gitmodules in d/watch is not a valid key. It's Git-Modules. Also there
> are no submodules from upstream so why is this set?

I removed it. It was likely a leftover from a copy/paste of another package.

> - The binary should be installed to usr/bin/whatwg-html-build, not
> usr/bin/html-build.

Instead of renaming the binary to the name of the package (which is likely a 
requirement from the Debian Policy, but I can't find it right now), I preferred 
to rename the package from "whatwg-html-build" to "html-build" (in line with 
the name in Cargo.toml). That way there is no need to patch the scripts that 
call this binary,


The salsa ci pipeline builds with the repo at my debusine workspace, to get 
rust-markup5ever-rcdom v0.40.
That's likely the reason why the debrebuild job fails.


Regards
Fab

Reply via email to