Package: lsb-base
Version: 3.1-10
Severity: normal
Tags: patch

I like using log_end_msg and co so that our packages can be easily
tuneable to various distro's idea of output.  However, having to trap
the return code of a log call is just silly.  We already know that
action failed - that's the return code we send to the log function.
Why does the log function have to return non-zero as well?

The attached patch fixes this.

Thanks,

--- /lib/lsb/init-functions     2006-06-05 20:57:40.000000000 +0100
+++ init-functions      2006-08-06 14:55:15.000000000 +0100
@@ -252,7 +252,6 @@
             echo " failed!"
         fi
     fi
-    return $1
+    return 0
 }

 log_action_msg () {


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-1-686
Locale: LANG=en_US.UTF8, LC_CTYPE=en_US.UTF8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF8)

Versions of packages lsb-base depends on:
ii  ncurses-bin                   5.5-2      Terminal-related programs and man 
ii  sed                           4.1.5-1    The GNU sed stream editor

lsb-base recommends no packages.

-- no debconf information

-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        [EMAIL PROTECTED] |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------

Attachment: signature.asc
Description: Digital signature

Reply via email to