Hi On Fri, Aug 25, 2006 at 06:13:15PM +0200, Miroslav Kure wrote: > Package: vserver-debiantools > Version: 0.3.0 > Severity: minor > > Hi Ola, > > I noticed that in 0.3.0 you changed the pattern for validating > hostnames from: > [a-z0-9]*([a-z0-9_-])[a-z0-9] > to: > [a-z0-9]*[a-z0-9_-][a-z0-9] > > That is wrong, because the former uses bash construction *() which > means zero or more occurences of characters inside the parenthesis, > while the latter * says any number of arbitrary characters, which > would allow hostmanes like a;'^%bc. > > The *() construction is only available in bash after setting > shopt -s extglob, but it is set at the begining of the scripts, so why > not use it. > > Next, I did mistake too, because the underscore is not valid in the > hostname, so please change the pattern to: > > [a-z0-9]*([a-z0-9-])[a-z0-9]
The reason for this was that bash -n script showed syntax error. I found it because lintian gave a warning. Have I missed something or is bash -n broken? Regards, // Ola > -- > Miroslav Kure > > -- --------------------- Ola Lundqvist --------------------------- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | +46 (0)54-10 14 30 +46 (0)70-332 1551 | | http://www.opal.dhs.org UIN/icq: 4912500 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
