Package: mp3wrap Version: 0.5-1 Severity: grave Tags: patch Justification: renders package unusable
Mp3wrap will not run. Regardless of whether any command line arguments are specified (valid or invalid, filenames or not; any or none), mp3wrap terminates with the error ‘Run without arguments to see HELP. Read man page for complete documentation’; it should only say this if an invalid response is entered. (Note that it still detects invalid options; but it quits at the end of processing arguments, before it does anything.) Sample run: (1) No args (should provide more help) ~ % mp3wrap Mp3Wrap Version 0.5 (2003/Jan/16). See README and COPYING for more! Written and copyrights by Matteo Trotta - <[EMAIL PROTECTED]> THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK! Run without arguments to see HELP. Read man page for complete \ documentation. (2) Invalid arg (correct) ~ % mp3wrap -h Mp3Wrap Version 0.5 (2003/Jan/16). See README and COPYING for more! Written and copyrights by Matteo Trotta - <[EMAIL PROTECTED]> THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK! mp3wrap: invalid option -- h Run without arguments to see HELP. Read man page for complete \ documentation. (3) Valid command line ~ % mp3wrap ALBUM * (should wrap album) Mp3Wrap Version 0.5 (2003/Jan/16). See README and COPYING for more! Written and copyrights by Matteo Trotta - <[EMAIL PROTECTED]> THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK! Run without arguments to see HELP. Read man page for complete \ documentation. This happens because it quits as soon as it process the last option, which is treated as invalid. If the type of the variable ‘option’ is changed from ‘char’ to ‘int’, the program works. A patch is attached. -- System Information: Debian Release: testing/unstable APT prefers testing APT policy: (500, 'testing') Architecture: powerpc (ppc64) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.16-2-powerpc64 Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) Versions of packages mp3wrap depends on: ii libc6 2.3.6-15 GNU C Library: Shared libraries Versions of packages mp3wrap recommends: ii mp3splt 2.1-1.1 Splits MP3 and Ogg Vorbis files wi -- no debconf information
--- mp3wrap.c.orig 2006-08-28 11:06:17.000000000 +0000 +++ mp3wrap.c 2006-08-28 11:16:31.000000000 +0000 @@ -70,8 +70,8 @@ FILE *file_output, *file_input; unsigned long splitpoints[MAXNUMFILE+1], begin=0, end, len=0, crc, fcrc; unsigned char filename[512], *wrapindex, c, ext[512]; - char option, *ptr; - int i = 0, j = 0, files, oldfiles = 0, indexsize=0, id3offset=0; + char *ptr; + int option, i = 0, j = 0, files, oldfiles = 0, indexsize=0, id3offset=0; short optoffset = 0, addoption = 0, listoption = 0, verboption = 0, ismp3wrap = 0; printf (NAME" Version "VERSION" "DATE". See README and COPYING for more!\n");
