Hi!
I can't determine that this comment should be send to bug#387658 that is already
closed. Let me know if you think this comment should be send as new bugreport.
I have installed bittornado 0.3.15-3, and confirmed that bug#387658 is fixed.
I have checked the source code of BitTornado to see what is actually changed to
launchmanycore.py from previous version.
Original upstream launchmanycore.py is as follow:
self.handler.listen_forever()
self.Output.message('shutting down')
self.hashcheck_queue = []
for hash in self.torrent_list:
self.Output.message('dropped
"'+self.torrent_cache[hash]['path']+'"')
self.downloads[hash].shutdown()
self.rawserver.shutdown()
except:
data = StringIO()
print_exc(file = data)
Output.exception(data.getvalue())
Debian bittornado 0.3.15-3 launchmanycore.py is as follow:
def start(self):
try:
self.handler.listen_forever()
self.hashcheck_queue = []
for hash in self.torrent_list:
self.Output.message('dropped
"'+self.torrent_cache[hash]['path']+'"')
self.downloads[hash].shutdown()
except:
data = StringIO()
print_exc(file=data)
self.Output.exception(data.getvalue())
self.rawserver.shutdown()
Although "self.rawserver.shutdown()" is placed inside of the try in upstream
code, that is placed outside of the try in Debian's code.
I don't know whether it will be a problem or not, but I think it is better to
move "self.rawserver.shutdown()" into the try.
It will be more in line with the original code.
I think launchmanycore.py should be write as:
def start(self):
try:
self.handler.listen_forever()
self.hashcheck_queue = []
for hash in self.torrent_list:
self.Output.message('dropped
"'+self.torrent_cache[hash]['path']+'"')
self.downloads[hash].shutdown()
self.rawserver.shutdown()
except:
data = StringIO()
print_exc(file=data)
self.Output.exception(data.getvalue())
Thanks,
Morita Sho
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
