Package: lvm2 Version: 2.02.06-2 Tags: patch When the lvm2 utilities vgchange, vgmknodes, et al, create the /dev/<vg>/<lv> symlinks, they do it like this lstat unlink symlink
This means that even if the vg is and remains active throughout, there is a moment when the symlink is missing. Any other program on the system which is referring to that lv may see this glitch and misbehave. The patch below fixes this. It now does this instead: stat symlink to /dev/<vg>/<lv>..tmp rename the ..tmp symlink to /dev/<vg>/<lv> FYI, we will be deploying this change in the forthcoming Ubuntu release. Thanks for your attention, Ian. diff -ruN --exclude='*~' orig/lvm2-2.02.06/lib/activate/fs.c lvm2-2.02.06/lib/activate/fs.c --- orig/lvm2-2.02.06/lib/activate/fs.c 2005-11-15 17:45:32.000000000 +0000 +++ lvm2-2.02.06/lib/activate/fs.c 2006-12-08 12:16:32.000000000 +0000 @@ -106,7 +106,7 @@ const char *lv_name, const char *dev) { char lv_path[PATH_MAX], link_path[PATH_MAX], lvm1_group_path[PATH_MAX]; - char vg_path[PATH_MAX]; + char vg_path[PATH_MAX], lv_path_tmp[PATH_MAX]; struct stat buf; if (lvm_snprintf(vg_path, sizeof(vg_path), "%s%s", @@ -123,6 +123,13 @@ return 0; } + if (lvm_snprintf(lv_path_tmp, sizeof(lv_path_tmp), "%s..tmp", + lv_path) == -1) { + log_error("Couldn't create temporary pathname for " + "logical volume link %s", lv_path); + return 0; + } + if (lvm_snprintf(link_path, sizeof(link_path), "%s/%s", dm_dir(), dev) == -1) { log_error("Couldn't create destination pathname for " @@ -160,17 +167,11 @@ link_path); return 0; } - - log_very_verbose("Removing %s", lv_path); - if (unlink(lv_path) < 0) { - log_sys_error("unlink", lv_path); - return 0; - } } - log_very_verbose("Linking %s -> %s", lv_path, link_path); - if (symlink(link_path, lv_path) < 0) { - log_sys_error("symlink", lv_path); + log_very_verbose("Linking %s -> %s", lv_path_tmp, link_path); + if (symlink(link_path, lv_path_tmp) < 0) { + log_sys_error("symlink", lv_path_tmp); return 0; } @@ -181,6 +182,12 @@ } #endif + log_very_verbose("Installing symlink %s as %s", lv_path_tmp, lv_path); + if (rename(lv_path_tmp, lv_path) < 0) { + log_sys_error("rename", lv_path_tmp); + return 0; + } + return 1; } -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]