[Vagrant Cascadian]
> +get_boolean(){
> + case "$(echo $1 | tr 'A-Z' 'a-z')" in
> + true|y|yes) return 0 ;;
> + *) return 1 ;;
> + esac
> +}
I'm not sure if this is a good function name for that operation. What
about boolean_is_true() or something like that. get_boolean()
indicate to me that it should return the value, and I expect to be
able to use it like VAL=`get_boolean $VAL`, and that is not the case
with this function.
Besides this minor point, the patch look good to me.
Friendly,
--
Petter Reinholdtsen
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
