[Cc list trimmed.]
On Sun, Mar 04, 2007 at 02:51:33PM -0600, [EMAIL PROTECTED] wrote:
> Thanks for the PNG patch. We'll get your other patches in ImageMagick
> 6.3.3-1 Beta as well.
Thanks. One note on your fix of the PCX heap overflow: From my reading
of the code, the correct allocation of the scanline array ought to read
scanline=(unsigned char *) AcquireMagickMemory(MagickMax(image->columns,
pcx_info.bytes_per_line)*Max(8,pcx_info.planes)*sizeof(*scanline));
to cover the loops over an eight bit wide mask, while your current
version in SVN reads
scanline=(unsigned char *) AcquireMagickMemory(4*MagickMax(image->columns,
pcx_info.bytes_per_line)*pcx_info.planes*sizeof(*scanline));
which still can be overflown for pcx_info.planes=1, unless I'm missing
something. Can you please check?
Regards,
Daniel.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
