On Friday 13 July 2007 16:20, Magnus Holmgren wrote: > tag 430508 upstream > tag 431239 upstream > thanks > > Any comments or objections to these patches? > http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;att=1;bug=430508 > http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;att=1;bug=431239
RFC conformance issues #431239 is a little more complex: The patch carries an LGPL copyright notification. Libspf2 is currently dual licensed under BSD and GPL version 2. I don't recall the exact rules on combining LGPL and GPL code (it hasn't come up in any packages I've done), but that needs to be considered. More important is that is LGPL code is incorporated, the package is no longer distributable under the BSD license. The patch submitter is, of course, free to license their work however they want, but the intent of the original author was clearly (I've discussed it with him) to have libspf2 be BSD distributable so it could be incorporated into closed products in order to better evangelize and spread the SPF technology. I'd recommend asking the submitter if they would relicense their patch under BSD/GPL v2. The Debian libpsf2 package is the most up to date currently and we have been pointing even non-Debian people to it, so this would have implications larger than Debian. It would be nice to be able to keep things the way the author wanted. From a technical perspective: Adding the Null Mail From HELO check is useful. The approach used here is consistent with the approach that many long standing SPF libraries (Mail::SPF::Query and pyspf for two) take. So this is good. The second part of the change, changing the SPF None response string from "%s is neither permitted nor denied by %s", to "%s doesn't provide an SPF record" is a wording improvement, but given that it's been this way for several years, I don't know if there are programs that are dependent on that string. So, I'd suggest this is an improvement, but not entirely without risk. I'd tend not to want to make it, but I could understand either way. Scott K P.S. Thanks for the chance to review the changes.
