On 17/07/07, Joey Hess <[EMAIL PROTECTED]> wrote:
Package: svn-buildpackage
Version: 0.6.21
Severity: normal
[EMAIL PROTECTED]:~package/xtris>svn-buildpackage --svn-tag-only
/home/joey/src/packages/xtris/.svn/deb-layout not found, importing settings via
Subversion properties...
Autodetecting remaining properties...
W: tagsUrl not specified anywhere, looking in the local repository...
Looking in SVN for:
svn+ssh://svn.kitenet.net/srv/svn/joey/trunk/src/packages/xtris/../tags/
svn+ssh://svn.kitenet.net/srv/svn/joey/trunk/src/packages/xtris/../../tags/xtris/
Repository lookup, probing
svn+ssh://svn.kitenet.net/srv/svn/joey/trunk/src/packages/tags...
Failed, assuming non-existent directory...Looking in SVN for:
svn+ssh://svn.kitenet.net/srv/svn/joey/trunk/src/packages/xtris/../tags/
svn+ssh://svn.kitenet.net/srv/svn/joey/trunk/src/packages/xtris/../../tags/xtris/
Repository lookup, probing
svn+ssh://svn.kitenet.net/srv/svn/joey/trunk/src/tags/xtris...
tagsUrl setting is required, but could not be found in
/home/joey/src/packages/xtris/.svn/deb-layout or repository tree.
Failed, assuming non-existent directory...zsh: exit 1 svn-buildpackage
--svn-tag-only
Well, that sucked. The problem with looking in only ../ and ../../ is
that yes, the tags can be in ../../../ or deeper. Not only my own
personal repo, but eg, the d-i repo, are set up this way.
I agree, the heuristic of that search is quite limited...
[EMAIL PROTECTED]:~package/xtris>svnpath
svn+ssh://svn.kitenet.net/srv/svn/joey/trunk/src/packages/xtris
[EMAIL PROTECTED]:~package/xtris>svnpath tags
svn+ssh://svn.kitenet.net/srv/svn/joey/tags/src/packages/xtris
Well, that was trivial. :-P svn-buildpackage could either use svnpath,
or just use its method, which is quite simple and works for nearly all
repo layouts: s/(trunk|branches)/tags/
Well, I guess using that simple method with replace is nice.
There is a catch, if
- the remote tags directory doesn't exist
- it was heuriticly detected
- a write in the tags directory is pending
then what should happen? Create the tags remote directory?
I am thinking about repos without the tagsUrl property explicitly set
and a non-standard tags location. Should I change the code to offer
support for this use case?
The code will be a lot simpler if I follow the scenario:
if no explict tagsUrl
detect tagsUrl with s/trunk/tags/ (or svnpath)
if tagsUrl does not exist
create it
tag
Note that this bug (my scenario, to be specific) is somewhat related
to #429024 and #408690.
--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
