On Tuesday 26 February 2008 04:09:48 Leszek Koltunski wrote:
> try running make-googleearth-package as root. You will notice it download
> the GoogleEarthLinux.bin installer, then it merrily announces 'Success!'
> but the package is nowhere to be found!

Well, I'll address this issue, but one thing that comes to mind is that 
running make-googleearth-package as root is actually not a great idea, 
since it actually has to execute (and thus trust) the binary it downloads 
in order to extract files. The next version will disallow running as root 
unless you --force it.

> Running it as normal user works as expected, (the .deb is found in
> current directory.)
>
> A little investigation revealed that this is due to incorrect permissions
> of the 'control' directory:

> 1) open up /usr/bin/make-googleearth-package and in line 397 remove the
> '>&2' from the 'dpkg-deb' command

BTW, to find problems easily, just use --verbose. It used to be the default, 
but too many people complained about all the output, so --quiet is now the 
default.

> 2) now you will notice the script fail with
>
> dpkg-deb: building package `googleearth' in
> `./googleearth_4.2.205.5730+0.5.3-1_i386.deb'. dpkg-deb: control
> directory has bad permissions 2755 (must be >=0755 and <=0775)

I'm not sure why this is happening; I can't reproduce it here either running 
it as root or using sudo. I really have no idea how you're getting the 
sticky bit set on the control file...

But one definite bug is that the return code of dpkg-deb isn't getting 
checked properly; hence the "Success!" when it actually failed. I'll 
address that in the next version as well.

-- 
Wesley J. Landaker <[EMAIL PROTECTED]> <xmpp:[EMAIL PROTECTED]>
OpenPGP FP: 4135 2A3B 4726 ACC5 9094  0097 F0A9 8A4C 4CD6 E3D2

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to