Hello,
Thank you for your comments.
On Mon, Jun 30, 2008 at 09:53:52AM -0400, Pascal Giard wrote:
> Sure, here are 5 comments
>
> 1) Original tarball and diff directory names don't match...
> Your orig tarball extracts to libQGLViewer-2.2.6-3 while the patch
> expects libqglviewer-2.2.6-3 .
Just use dpkg-source -x file.dsc to prepare sources.
> 2) Patches should not be executable. Please "chmod a-x" all your patches.
You mean patches in debian/patches/? I cannot check it just now (I'm not
at my workstation), but as far as I remember those patches are not
executable just after unpacking. It's probably dpatch's fault - I can
verify it later today.
> 3) Shouldn't you remove the dependency on libgl1-mesa-dev at all? I
> think this is at the root of the dependency on an obsolete package:
> xlibmesa-gl. Two Lintian warnings:
> E: libqglviewer-qt4-2: depends-on-obsolete-package depends: xlibmesa-gl
> E: libqglviewer-qt3-2: depends-on-obsolete-package depends: xlibmesa-gl
Could you tell me sth more about environment where you build the package
and about environment where you run lintian? Both are supposed to be current
unstable.
> 4) Is there really a need to keep the qt3 version in there?
For a period of time - yes. I know only of some group of people using
their own build with Qt4 because those people asked me about making
Qt4-flavour of QGLViewer package. I have no idea how many people have
their software linked with Qt3. I know about one piece of software
because it's available in Debian (complearn-gui) - it uses QGLViewer
linked with Qt3. And last but not least: Qt3 is still available in Debian.
I see no good reason to remove Qt3 flavour of QGLViewer before Qt3 itself.
> 5) Please consider renaming libqglviewer-qt4-2 to libqglviewer2. It
> will make it easier to upgrade seamlessly and reduce propagation time
> to debian archives. If you wanted to make it explicit that it's for
> qt4, you may want to create a dummy package...
Negative on that. Currently libqglviewer2 is linked with Qt3. If you
need to have your software linked with Qt4 (and Qt4 flavour of QGLViewer)
you need to rebuild your software regardless of name of package with
shared library. And last but not least - seamless upgrade is for users
of official Debian packages - sorry about that.
Regards
Artur
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
