On Tue, Jul 1, 2008 at 7:03 AM, Artur R. Czechowski <[EMAIL PROTECTED]> wrote: > Hello, > > Thank you for your comments.
No problem, hope this helps. > On Mon, Jun 30, 2008 at 09:53:52AM -0400, Pascal Giard wrote: >> Sure, here are 5 comments >> >> 1) Original tarball and diff directory names don't match... >> Your orig tarball extracts to libQGLViewer-2.2.6-3 while the patch >> expects libqglviewer-2.2.6-3 . > Just use dpkg-source -x file.dsc to prepare sources. Thanks, works fine. >> 2) Patches should not be executable. Please "chmod a-x" all your patches. > You mean patches in debian/patches/? I cannot check it just now (I'm not > at my workstation), but as far as I remember those patches are not > executable just after unpacking. It's probably dpatch's fault - I can > verify it later today. Using dpkg-source, patches are not executable. >> 3) Shouldn't you remove the dependency on libgl1-mesa-dev at all? I >> think this is at the root of the dependency on an obsolete package: >> xlibmesa-gl. Two Lintian warnings: >> E: libqglviewer-qt4-2: depends-on-obsolete-package depends: xlibmesa-gl >> E: libqglviewer-qt3-2: depends-on-obsolete-package depends: xlibmesa-gl > Could you tell me sth more about environment where you build the package > and about environment where you run lintian? Both are supposed to be current > unstable. I've ran lintian with same results on two different Debian unstable systems. One being i386 and the other amd64. That's weird because your depend on "libgl-dev | libgl1-mesa-dev" is right! After rebuilding desmume out of my chroot, i'm convinced that the problem is because i'm using nvidia-glx-legacy-96xx. I don't know how come xlibmesa-gl turns up instead of libgl1-mesa-glx after shlibs... Any idea how i could track this? Building in my 32bit chroot (no nvidia stuff) gives the right results. Btw, i forgot to mention the lintian warning about out of date Standards-Version: W: libqglviewer source: out-of-date-standards-version 3.7.3 (current is 3.8.0) >> 4) Is there really a need to keep the qt3 version in there? > For a period of time - yes. [...] >> 5) Please consider renaming libqglviewer-qt4-2 to libqglviewer2. It >> will make it easier to upgrade seamlessly and reduce propagation time >> to debian archives. If you wanted to make it explicit that it's for >> qt4, you may want to create a dummy package... > Negative on that. Currently libqglviewer2 is linked with Qt3. If you > need to have your software linked with Qt4 (and Qt4 flavour of QGLViewer) > you need to rebuild your software regardless of name of package with > shared library. And last but not least - seamless upgrade is for users > of official Debian packages - sorry about that. Ok, agreed with 4 and 5. ;-) Cheers and thanks for your work on qglviewer. -Pascal PS: Do you plan to add the designerPlugin anytime soon? -- Homepage (http://organact.mine.nu) Debian GNU/Linux (http://www.debian.org) LACIME: École de technologie supérieure (http://lacime.etsmtl.ca) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
