On Fri, Feb 27, 2009 at 09:23:26AM +0100, Stefano Zacchiroli wrote: > > Would it make sense to instead rule out any character that would be > > a part of a package name? > > Uhm, I don't think so, because that set of characters is not > "symmetric", e.g. a package cannot start with a -, but can contain it > and other similar details. You can of course come up with a proper > regexp, but I found delimiters more appropriate for this specific > case.
Ok. > When I first hacked up the patch, I did not get that those flags were > specific of grep-dctrl pattern "particles" (i.e., that --whole-pkg > should be repeated on different sub-patterns). Now that I'm aware of > it, I think it does make sense, what's your take on it? > > Nevertheless, that "implication" is currently annoying for the user > because if you specify both -e and --whole-pkg you will get an > error. What would be your preferred fix for this? The error is from set_mode, yes? Probably should have it suppress the error if you specify the same mode multiple time. -- Antti-Juhani Kaijanaho, Jyväskylä, Finland http://antti-juhani.kaijanaho.fi/newblog/ http://www.flickr.com/photos/antti-juhani/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
