I demand that Marc Dequènes (Duck) may or may not have written...

> Coin,

?

> Please consider applying this patch in your next release, so as to add  
> support for the Hurd system. It contains seveval parts :

> - posixness_fix patch: relying on PATH_MAX unconditionnaly is an important
> POSIX incompatibility; The Hurd does not need such limit so it is not
> defined. The best fix would be to rewrite several parts of the software to
> use dynamic allocation when PATH_MAX is not defined, but this would be
> larger and more complex changes, so this small workaround would be enough
> at the moment

Agreed, but sending the full version upstream would be good.

> - hurd_support patch: a very short Hurd-specific patch to correct use of an
> include file not needed and not existing on Hurd

Seems fine (so long as it doesn't break things elsewhere).

> - dvb_optional patch: we cannot build with DVB support on Hurd, due to
> missing and currently unimplementable ioctls, so this patch, along with the
> 'reautogen' patch add the necessary configure option to deactivate DVB
> support on Hurd

No.

The option is acceptable, but the test must be "= yes" on (at least) Windows
& Hurd and "!= no" elsewhere. I will *not* accept DVB being disabled by
default when building xine-lib on systems where the plugin is buildable and
will work.

> - rules changes to use the new DVB configure option and adapt the list of
> files to install; this is very similar to the kfreebsd needs Also, please
> help us push the software changes back upstream, so maintenance would be a
> lot easier.

A patch series against http://hg.debian.org/hg/xine-lib/pkg/xine-lib-deb
would be much preferred since it can easily be applied upstream ("hg
transplant", mostly), though debian/rules might be a bit tricky.

(An "hg bundle"-generated file is fine for this.)

-- 
| Darren Salt      | linux at youmustbejoking | nr. Ashington, | Doon
| Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
| + Generate power using sun, wind, water, nuclear.      FORGET COAL AND OIL.

If you have nothing to say, please only say it once!



--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to