Coin, Quoting Darren Salt <[email protected]>:
Coin,?
I'm a duck, so i say Quack (or Coin in french) :-).
Agreed, but sending the full version upstream would be good.
As such kind of problems are... numerous, this is done as a best-effort basis. If it was to add Hurd-specific features, i would agree not to accept such kind of patches, but in this case the software itself does not respect standards. Fortunately, its works well on the mainstream GNU/Linux system, but this is not to say this non-Hurd-specific bug has not to be solved. I hope either we get time to provide a better patch, or the upstream authors would be alerted and come back to us to work together on a fix. Until then, i hope this blocker will nevertheless be unlocked.
- hurd_support patch: a very short Hurd-specific patch to correct use of an include file not needed and not existing on HurdSeems fine (so long as it doesn't break things elsewhere).
The __GNU__ symbol is defined only on the GNU system, aka Hurd.
- dvb_optional patch: we cannot build with DVB support on Hurd, due to missing and currently unimplementable ioctls, so this patch, along with the 'reautogen' patch add the necessary configure option to deactivate DVB support on HurdNo. The option is acceptable, but the test must be "= yes" on (at least) Windows & Hurd and "!= no" elsewhere. I will *not* accept DVB being disabled by default when building xine-lib on systems where the plugin is buildable and will work.
I don't understand. The --disable-dbv is only added to the configure options on Hurd, and as it reads itself, it intends to disable support "on demand", while obviouly the original default to yes is kept. Perhaps you mean the AM_CONDITIONAL test is badly done, in this case please help me fix it, as i don't see what's wrong.
A patch series against http://hg.debian.org/hg/xine-lib/pkg/xine-lib-deb would be much preferred since it can easily be applied upstream ("hg transplant", mostly), though debian/rules might be a bit tricky. (An "hg bundle"-generated file is fine for this.)
Arf. I guess this patch would go to trash if i don't do so, but i'm not so happy having to learn every VCS in the world because a simple unified patch is not trendy enough nowadays.
Regards. -- Marc Dequènes (Duck)
pgpkjwVC6Gv0L.pgp
Description: PGP Digital Signature
