Joey Hess wrote: > Thierry Carrez wrote: >> etckeeper currently runs "etckeeper init" in postinst, as a fix for bug >> 505772. However this bug suggested to run both init and commit at >> install-time, in order to have a working setup just after the install >> command. >> >> This makes sense especially as the nifty "etckeeper uninit" allows you >> to undo both init and commit anyway. > > The reason I don't immediatly autocommit is because the user might want > to examine the files that etckeeper has added to version control and > remove some of them from it, for security or clutter reasons. They also > might want to update the VCS's ignore file. It makes sense to let them > do so before the initial commit. > > Of course, the commit will probably happen soon after install anyway, > either by the cron job, or by another apt run triggering it. Still, at > least this way the user has a window and doesn't need to do a tedious > uninit and reinit.
Yes, it's obviously a trade-off between: * Having it up and running just after installation * Offering systematically the opportunity to review the added set My (final) goal for etckeeper is to make it a potential default install target (in Ubuntu), so that people can run it without even knowing it's there, and when they happen to need the history they can learn more about it and discover that it's been logging changes all along. That was the idea behind the daily autocommit. With that goal in mind, it makes sense for us to balance the tradeoff in the "up without any user interaction" direction. We make it easier for newbies, at the expense of making it slightly harder for experienced users (potential need to uninit + init + add + commit if you want to edit the set manually). However I'd perfectly understand if you prefer to balance that trade-off in the other direction in Debian :) I just submitted the idea, because the less delta we have the better it is for everyone. How often do you think admins need to edit the added file set for security/clutter reasons ? Cheers, -- Thierry -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
