On Sat, Aug 22, 2009 at 01:06:14PM +0200, Frans Pop wrote:
> On Saturday 22 August 2009, Craig Sanders wrote:
> > experimental's suite and codename are the same so debmirror fails and
> > aborts when it tries renaming it.
>
> Thanks for reporting that corner case Craig.
no problem. i don't want to have to patch it myself on every upgrade :)
> Your patch will work, but I think I prefer to test for this earlier so
> it never gets to the rename function, so I've committed:
yep, that's better. mine was just a Q&D hack, from near-zero knowledge of
the debmirror code, just to get it running ASAP.
> --- a/debmirror
> +++ b/debmirror
> @@ -739,7 +739,8 @@ foreach my $dist (@rdists) {
> $codename = $dist;
> }
> die("Duplicate Codename $codename.\n") if exists $dists{$codename};
> - $suite = "" if (! $suite);
> + # For experimental the suite is the same as the codename
> + $suite = "" if (! $suite || $suite eq $codename);
> $dists{$codename} = "$suite";
>
> # This should be a one-time conversion only
>
> Could you verify that this solves the problem too?
i'll try it tomorrow, but it seems pretty clear that it will work.
craig
--
craig sanders <[email protected]>
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
