After a few hundred cycles of testing, this patch is looking solid. Running with checksumming enabled, and debugging disabled, error.log and db.log remain at zero size.
Oh, but there was one minor issue. I was previously seeing this warning come up repeatedly in error.log: Tue Sep 1 18:10:46 2009|warn [25867]: Use of uninitialized value $cache_status in concatenation (.) or string at apt-cacher2 line 1053. That's from the print() statement in writeaccesslog(). Apparently, the $cache_status variable in handle_connection() was not getting set to anything. I worked around this by initializing the variable with a value, but I don't think this is what should be happening. Not only are there checks further down that seem to account for an unset value---of 50K+ lines in the access.log file here, almost 92% of them show the initial value that I put in. -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
