Package: fsl Version: 4.1.4-2 Severity: important Tags: patch User: [email protected] Usertags: origin-ubuntu karmic ubuntu-patch
Function `fileno' implicitly converted to pointer at wpng.c:279 An automated build log filter[1] detected the problem(s) above that will likely cause your package to segfault on 64-bit architectures (where the size of a pointer is greater than the size of an integer.) This is often due to a missing function prototype definition. For more information, see [2]. Since use of implicitly converted pointers is always (eventually and/or itermittantly) fatal to the application, they are errors. Please correct them for your next upload. [1] http://people.debian.org/~dannf/check-implicit-pointer-functions [2] http://wiki.debian.org/ImplicitPointerConversions *** /tmp/tmpulZcnC In Ubuntu, we've applied the attached patch to achieve the following: * src/miscvis/wpng.c: Define _GNU_SOURCE to fix an ANSI C warning from the use of fdopen and fileno. LP: #402174 We thought you might be interested in doing the same. -- System Information: Debian Release: squeeze/sid APT prefers karmic-updates APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic') Architecture: i386 (i686) Kernel: Linux 2.6.31-10-generic (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
--- fsl-4.1.4.orig/src/miscvis/wpng.c +++ fsl-4.1.4/src/miscvis/wpng.c @@ -56,6 +56,9 @@ #define VERSION "1.03 of 19 March 2000" #define APPNAME "Simple PGM/PPM/PAM to PNG Converter" +#define _GNU_SOURCE 1 +#define POSIX_SOURCE 1 + #if defined(__MSDOS__) || defined(__OS2__) # define DOS_OS2_W32 #elif defined(_WIN32) || defined(__WIN32__)
