Hi Michael, thanks for your report.
On Thu, Sep 10, 2009 at 12:11:27PM -0400, Michael Terry wrote: > Function `fileno' implicitly converted to pointer at wpng.c:279 > > An automated build log filter[1] detected the problem(s) above that will > likely cause your package to segfault on 64-bit architectures (where the > size of a pointer is greater than the size of an integer.) > > This is often due to a missing function prototype definition. > For more information, see [2]. > > Since use of implicitly converted pointers is always (eventually > and/or itermittantly) fatal to the application, they are errors. > Please correct them for your next upload. > > [1] http://people.debian.org/~dannf/check-implicit-pointer-functions > [2] http://wiki.debian.org/ImplicitPointerConversions > > *** /tmp/tmpulZcnC > In Ubuntu, we've applied the attached patch to achieve the following: > > * src/miscvis/wpng.c: Define _GNU_SOURCE to fix an ANSI C warning from > the use of fdopen and fileno. LP: #402174 > > We thought you might be interested in doing the same. I'm thinking about disabling the '-ansi -pedantic' combo as a whole. The sources do not seem to be consistently intended to be ANSI C/C++. As far as I can see there shouldn't be any disadvantages. Or am I wrong? Thanks, Michael -- GPG key: 1024D/3144BE0F Michael Hanke http://apsy.gse.uni-magdeburg.de/hanke -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
