On Sun, Nov 29, 2009 at 09:50:31AM +0100, Michael Biebl wrote:
> Josh Triplett wrote:
> > Package: pm-utils
> > Version: 1.2.6.1-2
> > Severity: normal
> > 
> > pm-utils 1.2.6.1-2 patched on_ac_power to try devicekit-power:
> > 
> >   * Add 03-on_ac_power-devkit-power.patch: Try to contact DeviceKit-Power in
> >     on_ac_power, and if it succeeds, use that. Otherwise fall back to hal.
> > 
> > However, pm-utils doesn't actually *ship* on_ac_power, preferring
> > instead to use the version from powermgmt-base.
> > 
> > The version from pm-utils uses hal, and with this change also
> > devicekit-power.  The version from powermgmt-base checks /sys, PMU, and
> > APM directly.  It looks like these versions need merging into some
> > common implementation, probably the one in powermgmt-base for use by
> > other packages.  pm-utils could then drop the recommendation for hal
> > (and not add one for devicekit-power as proposed in my previous bug
> > report).
> 
> As already explained, the hal recommends is not for on_ac_power.
> I specifically decided to drop the internal on_ac_power script from pm-utils 
> as
>  I figured powermgmt-base is the canonical implementation you are asking for 
> and
> there was a file conflict. So instead of of moving pm-utils's on_ac_power to
> something to a private directory (/usr/lib/pm-utils), I decided to just drop 
> it
> and use powermgmt-base instead.
> Shipping 03-on_ac_power-devkit-power.patch seems to have caused some 
> confusion,
> nonetheless I don't see a bug here, so closing.

A bug *does* exist here: on_ac_power from pm-utils has functionality
that on_ac_power from powermgmt-base does not, namely the ability to
check with hal (and now devicekit-disks).  on_ac_power from
powermgmt-base ought to incorporate that functionality.

- Josh Triplett



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to