Hi,

have you tested your patch with existing non-empty quilt series ?

On Fri, 04 Dec 2009, David Paleino wrote:
> ++    cat_series
> ++    local retval=$?
> ++
> +     local patch=$(cat_series | head -n 1)

The first call to cat_series might output lines that will be considered as
the return value of the function... and thus it would not work at all.
Calling cat_series twice is also not ideal.

This might be better:
        local series=$(cat_series)
        local retval=$?
        local patch=$(echo $series | head -n 1)

Before creating more patches, please consider my advice in the other mail.
We need more help cooperating with upstream rather than creating more
patches to forward/get merged.

Cheers,
-- 
Raphaƫl Hertzog



--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to