On Friday 04 December 2009 11:13:15, Raphael Hertzog wrote: > Hi, > > have you tested your patch with existing non-empty quilt series ?
Ouch! > [..] > This might be better: > local series=$(cat_series) > local retval=$? > local patch=$(echo $series | head -n 1) Unfortunately this does not work. I added a printf "$retval\n" just before the [ -z "$patch" ] and: $ quilt push 0 No patches in series $ I suspect that $? catches the variable assignment rather than the launched command. I agree that calling cat_series twice is rather suboptimal, but I suppose we could fix my previous patch just by adding >/dev/null to the first call. Anyways, I'll look a bit more into it, and try to have a cleaner patch. > Before creating more patches, please consider my advice in the other mail. > We need more help cooperating with upstream rather than creating more > patches to forward/get merged. Ok, sure. But I'm not creating patches specific to Debian, am I? ;) Kindly, David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 ----|---- http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
signature.asc
Description: This is a digitally signed message part.
