> Source: freewnn
> Version: 1.1.0+1.1.1-a021-1.3
> Severity: wishlist
> User: [email protected]
> Usertags: unresolved-symbols-so
>
> I build all packages some time ago with binutils-gold and your package
build
> without an hard failure, but I noticed that you seems to provide a
library in
> a specific library package so other packages can link against it without
> problems.... but your shared object has still some unresolved symbols which
> the program which links agaomst it must resolve. This isnt a good idea
because
> when you introduce new dependencies the package previously linked
against the
> old version will break because it doesnt know about the new dependency.
> Maybe you could link against all needed libraries so programs must not link
> against libraries which it doesnt need to use.
Upstream adds (conceptially) attached change to tell dependent library
to libwnn0 (etc) on link time. Does that make sense?
----
Tomoki AONO ([email protected])
diff -ur ../FreeWnn-1.1.1-a021.orig/Wnn/jlib/Makefile.in ./Wnn/jlib/Makefile.in
--- ../FreeWnn-1.1.1-a021.orig/Wnn/jlib/Makefile.in 2004-09-13 01:56:55.000000000 +0900
+++ ./Wnn/jlib/Makefile.in 2010-01-11 01:36:50.000000000 +0900
@@ -93,7 +93,7 @@
kankana: kankana.o
$(RM) $@
- $(LIBTOOL) --mode=link $(CCLINK) -o $@ $(LDOPTIONS) kankana.o $(WNNJLIB) @LIBS@
+ $(LT_LD) -o $@ $(LDOPTIONS) kankana.o $(WNNJLIB)
clean::
$(RM) kankana
@@ -101,7 +101,7 @@
all:: libwnn.la
libwnn.la: $(OBJS) $(EXTRALIBRARYDEPS)
- $(LIBTOOL) --mode=link $(CC) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(WNNJLIBVERSION)
+ $(LT_LD) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(WNNJLIBVERSION) @LIBS@
lintlib:: llib-lwnn.ln
diff -ur ../FreeWnn-1.1.1-a021.orig/Wnn/jlib.V3/Makefile.in ./Wnn/jlib.V3/Makefile.in
--- ../FreeWnn-1.1.1-a021.orig/Wnn/jlib.V3/Makefile.in 2003-05-12 03:31:44.000000000 +0900
+++ ./Wnn/jlib.V3/Makefile.in 2010-01-11 01:36:50.000000000 +0900
@@ -71,12 +71,12 @@
.c.o:
$(RM) $@
- $(LIBTOOL) $(CC) -c $(CFLAGS) $(_NOOP_) $*.c
+ $(LT_CC) -c $(CFLAGS) $(_NOOP_) $<
all:: libjd.la
libjd.la: $(OBJS) $(EXTRALIBRARYDEPS)
- $(LIBTOOL) $(CC) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(WNNJLIBVERSION)
+ $(LT_LD) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(WNNJLIBVERSION) @LIBS@
lintlib:: llib-ljd.ln
@@ -109,13 +109,13 @@
done
$(OBJ2) : $(SRC2)
- $(LIBTOOL) $(CC) -c $(CFLAGS) $(WNNETCSRC)/`basename $@ .o`.c
+ $(LT_CC) -c $(CFLAGS) $(WNNETCSRC)/`basename $@ .o`.c
$(OBJ3) : $(SRC3)
- $(LIBTOOL) $(CC) -c $(CFLAGS) $(WNNETCSRC)/`basename $@ .o`.c
+ $(LT_CC) -c $(CFLAGS) $(WNNETCSRC)/`basename $@ .o`.c
$(OBJ4) : $(SRC4)
- $(LIBTOOL) $(CC) -c $(CFLAGS) $(WNNETCSRC)/`basename $@ .o`.c
+ $(LT_CC) -c $(CFLAGS) $(WNNETCSRC)/`basename $@ .o`.c
depend:: .depend
Only in ./Wnn/jlib.V3: Makefile.in.orig
Only in ./Wnn/jlib.V3: Makefile.in.rej
diff -ur ../FreeWnn-1.1.1-a021.orig/cWnn/jlib/Makefile.in ./cWnn/jlib/Makefile.in
--- ../FreeWnn-1.1.1-a021.orig/cWnn/jlib/Makefile.in 2004-09-13 01:56:55.000000000 +0900
+++ ./cWnn/jlib/Makefile.in 2010-01-11 01:36:50.000000000 +0900
@@ -119,7 +119,7 @@
all:: libcwnn.la
libcwnn.la: $(OBJS) $(EXTRALIBRARYDEPS)
- $(LIBTOOL) --mode=link $(CC) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(CWNNJLIBVERSION)
+ $(LT_LD) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(CWNNJLIBVERSION) @LIBS@
lintlib:: llib-lcwnn.ln
diff -ur ../FreeWnn-1.1.1-a021.orig/kWnn/jlib/Makefile.in ./kWnn/jlib/Makefile.in
--- ../FreeWnn-1.1.1-a021.orig/kWnn/jlib/Makefile.in 2004-09-13 01:56:55.000000000 +0900
+++ ./kWnn/jlib/Makefile.in 2010-01-11 01:36:50.000000000 +0900
@@ -130,7 +130,7 @@
all:: libkwnn.la
libkwnn.la: $(OBJS) $(EXTRALIBRARYDEPS)
- $(LIBTOOL) --mode=link $(CC) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(KWNNJLIBVERSION)
+ $(LT_LD) -o $@ $(OBJS:.o=.lo) -rpath $(WNNLIBDIR) -version-info $(KWNNJLIBVERSION) @LIBS@
lintlib:: llib-lkwnn.ln
diff -ur ../FreeWnn-1.1.1-a021.orig/makerule.mk.in ./makerule.mk.in
--- ../FreeWnn-1.1.1-a021.orig/makerule.mk.in 2003-05-12 03:22:57.000000000 +0900
+++ ./makerule.mk.in 2010-01-11 01:36:50.000000000 +0900
@@ -72,6 +72,10 @@
RANLIBINSTFLAGS =
LIBTOOL = @LIBTOOL@
+# LT_* : shortcut for Makefile.in
+ LT_CC = $(LIBTOOL) --mode=compile $(CC)
+ LT_LD = $(LIBTOOL) --mode=link $(CCLINK)
+ LT_INSTALL = $(LIBTOOL) --mode=install $(INSTALL)
RM = rm -f
TBL = tbl
