Kyle Moffett <[email protected]> writes:
> When using "rebuildd-job", it will completely silently fail for many
> different kinds of syntax or data errors. For example, if an
> architecture is specified which is not enabled in the config file, it
> will accept the input and exit without doing anything.
>
> Connecting over the "telnet" interface is not much better; the error
> message that is returned is completely generic. I had to manually
> add debug messages to the python scripts to figure out where the error
> was.
It probably deserve another and different bug report. I can just agree
with your statement anyway. Patch welcome. :-)
> The "rebuildd" tool itself also has several silent failures, one of
> which will cause a Job object to get stuck in the "BUILDING" state. In
> the "Job->run()" function, for the code block that looks like this:
>
> try:
> proc = subprocess.Popen(cmd.split(), [.....])
> except Exception, error:
> state = 1
> break
> state = proc.poll()
>
> If an exception occurs, such as "No such file or directory", the Job
> will silently fail and get stuck in the "BUILDING" state. To fix this,
> I inserted code so that it looked like this:
>
> try:
> proc = subprocess.Popen(cmd.split(), [.....])
> except Exception, error:
> build_log.write("Unable to execute command \"%s\": %s" %
> (cmd, error))
> with self.status_lock:
> self.status = failed_status
> state = 1
> break
> state = proc.poll()
Sounds like a mean bug indeed. I'll try to make a patch, if you don't
send one by that time.
<#secure method=pgpmime mode=sign>
--
Julien Danjou
// ᐰ <[email protected]> http://julien.danjou.info
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
