Package: cimg
Version: 1.4.4-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu natty ubuntu-patch

Hi,

Sorry to bug you again with that, but a new FTBFS appeared in 1.4.4 with missing
libX11 when linking the examples. Here is the relevant part of the build log:
...
g++ -o gmic_gimp gmic_gimp.cpp gmic_gimp.o -Dcimg_build `gimptool-2.0 --cflags` 
`gimptool-2.0 --libs` -lpthread  -lfftw3 -lpng -lz 
/usr/bin/ld: /tmp/ccfFCi4P.o: undefined reference to symbol 
'XGetWindowAttributes'
/usr/bin/ld: note: 'XGetWindowAttributes' is defined in DSO 
/usr/lib/libX11.so.6 so try adding it to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make[3]: *** [gmic_gimp] Error 1

The fix is different than the previous one, as gmic_gimp is not using LDFLAG, so
it's necessary to patch the Makefile file, as you can see in the next patch:
*** /tmp/tmpuilFjM

I haven't applied the patch yet in UbuntuDA, even if have the package ready.
Just tell me if you think I should upload it, without waiting for you.

Thanks,
Fabrice


-- System Information:
Debian Release: squeeze/sid
  APT prefers maverick-updates
  APT policy: (500, 'maverick-updates'), (500, 'maverick-security'), (500, 
'maverick-proposed'), (500, 'maverick')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-23-generic (SMP w/2 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru cimg-1.4.4/debian/patches/20_fix-missing-libX11-binutils-gold.patch cimg-1.4.4/debian/patches/20_fix-missing-libX11-binutils-gold.patch
--- cimg-1.4.4/debian/patches/20_fix-missing-libX11-binutils-gold.patch	1970-01-01 01:00:00.000000000 +0100
+++ cimg-1.4.4/debian/patches/20_fix-missing-libX11-binutils-gold.patch	2010-11-12 07:00:11.000000000 +0100
@@ -0,0 +1,15 @@
+Description: Fix a FTBFS with binutils-gold when building gmic_gimp because of
+ missing XGetWindowAttributes symbol, found in libX11. Adding thus -lX11 to link
+ options of gmic_gimp.
+Author: Fabrice Coutadeur <[email protected]>
+--- cimg-1.4.4.orig/examples/Makefile
++++ cimg-1.4.4/examples/Makefile
+@@ -288,7 +288,7 @@ gmic_gimp.o: gmic.cpp gmic_def.h
+ 	$(CC) -o gmic_gimp.o -c gmic.cpp -Dcimg_build -Dgmic_gimp -Dgmic_minimal $(CIMG_OPT_CFLAGS) $(CIMG_FFTW3_CFLAGS) $(CIMG_PNG_CFLAGS)
+ 
+ gmic_gimp: gmic_gimp.o gmic_gimp.cpp
+-	$(CC) -o $(EXEPFX)gmic_gimp gmic_gimp.cpp gmic_gimp.o -Dcimg_build `gimptool-2.0 --cflags` `gimptool-2.0 --libs` -lpthread $(CIMG_OPT_FLAGS) $(CIMG_FFTW3_LDFLAGS) $(CIMG_PNG_LDFLAGS) $(CIMG_GIMP_CFLAGS)
++	$(CC) -o $(EXEPFX)gmic_gimp gmic_gimp.cpp gmic_gimp.o -Dcimg_build `gimptool-2.0 --cflags` `gimptool-2.0 --libs` -lpthread $(CIMG_OPT_FLAGS) $(CIMG_FFTW3_LDFLAGS) $(CIMG_PNG_LDFLAGS) $(CIMG_GIMP_CFLAGS) -lX11
+ 
+ # Specific targets for 'gmic'.
+ gmic_def: gmic_def.gmic
diff -Nru cimg-1.4.4/debian/patches/series cimg-1.4.4/debian/patches/series
--- cimg-1.4.4/debian/patches/series	2010-11-05 11:58:19.000000000 +0100
+++ cimg-1.4.4/debian/patches/series	2010-11-12 06:55:40.000000000 +0100
@@ -1 +1,2 @@
 10_examples.patch
+20_fix-missing-libX11-binutils-gold.patch

Reply via email to