Bug#615477: don't include whitespaces in watch file of sendmail

Sat, 26 Feb 2011 11:03:27 -0800 

Package: sendmail
Version: 8.14.4-2

uscan.pl cannot find the latest tar ball released by the upstream project
because the ftp directory of the upstream project holds a symbolic link:

    $ lftp ftp://ftp.sendmail.org/pub/sendmail
    cd ok, cwd=/pub/sendmail
    lftp ftp.sendmail.org:/pub/sendmail> ls
    ls
    total 48936
    drwxrwx--x  2 gshapiro  sendmail      512 Dec 28 18:31 .alpha
    drwxrwx--x  3 gshapiro  sendmail      512 Nov 20 23:01 .beta
    ...
    lrwxr-xr-x  1 ca        sendmail       39 Dec  5 00:36 
sendmail.8.14.5.Beta0.tar.gz -> .beta/late/sendmail.8.14.5.Beta0.tar.gz
    lrwxr-xr-x  1 ca        sendmail       43 Dec  5 00:36 
sendmail.8.14.5.Beta0.tar.gz.sig -> .beta/late/sendmail.8.14.5.Beta0.tar.gz.sig
    lftp ftp.sendmail.org:/pub/sendmail> 

The pattern of thewatch file of sendmail accepts any character:

    ftp://ftp.sendmail.org/pub/sendmail/sendmail\.(.*)\.tar\.gz debian 

Therefore whole "sendmail.8.14.5.Beta0.tar.gz -> 
.beta/late/sendmail.8.14.5.Beta0.tar.gz" is 
recognized as a file name. As you know the file name here is 
"sendmail.8.14.5.Beta0.tar.gz".

The way to reproduce:
    $ cat /tmp/tmp.WEaYmomwtj/.watch
    # format version number, currently 3; this line is compulsory!
    version=3

    # Line continuations are performed with \
    # Full-site-with-pattern  [Version  [Action]]
    opts=pasv ftp://ftp.sendmail.org/pub/sendmail/sendmail\.(.*)\.tar\.gz 
debian 
    opts=pasv ftp://ftp.sendmail.org/pub/sendmail/sendmail\.(.*)\.tar\.gz\.sig 
debian

    $ perl -I /home/jet/.debwatch/devscripts 
/home/jet/.debwatch/devscripts/scripts/uscan.pl --package sendmail 
--upstream-version 0.0.0 --watchfile /tmp/tmp.WEaYmomwtj/.watch --download 
--dehs --destdir /tmp/tmp.WEaYmomwtj --repack --symlink 
    <tch --download --dehs --destdir /tmp/tmp.WEaYmomwtj --repack --symlink 
    <dehs>
    dpkg: version '8.14.5.Beta0.tar.gz -> .beta/late/sendmail.8.14.5.Beta0' has 
bad syntax: version string has embedded spaces
    dpkg: version '8.14.5.Beta0.tar.gz -> .beta/late/sendmail.8.14.5.Beta0' has 
bad syntax: version string has embedded spaces
    <package>sendmail</package>
    <debian-uversion>0.0.0</debian-uversion>
    <debian-mangled-uversion>0.0.0</debian-mangled-uversion>
    <upstream-version>8.14.5.Beta0.tar.gz -&amp;gt; 
.beta/late/sendmail.8.14.5.Beta0</upstream-version>
    
<upstream-url>ftp://ftp.sendmail.org/pub/sendmail/sendmail.8.14.5.Beta0.tar.gz 
-&amp;gt; .beta/late/sendmail.8.14.5.Beta0.tar.gz</upstream-url>
    <status>Newer version available</status>
    <warnings>uscan.pl warning: Downloading
     ftp://ftp.sendmail.org/pub/sendmail/sendmail.8.14.5.Beta0.tar.gz -&amp;gt; 
.beta/late/sendmail.8.14.5.Beta0.tar.gz failed:
    404 Can't chdir to sendmail.8.14.5.Beta0.tar.gz -&amp;gt; .beta</warnings>
    dpkg: version '8.14.5.Beta0.tar.gz.sig -> .beta/late/sendmail.8.14.5.Beta0' 
has bad syntax: version string has embedded spaces
    dpkg: version '8.14.5.Beta0.tar.gz.sig -> .beta/late/sendmail.8.14.5.Beta0' 
has bad syntax: version string has embedded spaces
    <package>sendmail</package>
    <debian-uversion>0.0.0</debian-uversion>
    <debian-mangled-uversion>0.0.0</debian-mangled-uversion>
    <upstream-version>8.14.5.Beta0.tar.gz.sig -&amp;gt; 
.beta/late/sendmail.8.14.5.Beta0</upstream-version>
    
<upstream-url>ftp://ftp.sendmail.org/pub/sendmail/sendmail.8.14.5.Beta0.tar.gz.sig
 -&amp;gt; .beta/late/sendmail.8.14.5.Beta0.tar.gz.sig</upstream-url>
    <status>Newer version available</status>
    <warnings>uscan.pl warning: Downloading
     ftp://ftp.sendmail.org/pub/sendmail/sendmail.8.14.5.Beta0.tar.gz.sig 
-&amp;gt; .beta/late/sendmail.8.14.5.Beta0.tar.gz.sig failed:
    404 Can't chdir to sendmail.8.14.5.Beta0.tar.gz.sig -&amp;gt; 
.beta</warnings>
    </dehs>



I think " -> " should be handled in uscan.pl.
Here is a quick fix.

diff -uN watch watch.new
--- watch      2011-02-27 01:40:24.427632180 +0900
+++ watch.new  2011-02-27 01:40:31.567371805 +0900
@@ -3,5 +3,5 @@
 
 # Line continuations are performed with \
 # Full-site-with-pattern  [Version  [Action]]
-opts=pasv ftp://ftp.sendmail.org/pub/sendmail/sendmail\.(.*)\.tar\.gz debian 
-opts=pasv ftp://ftp.sendmail.org/pub/sendmail/sendmail\.(.*)\.tar\.gz\.sig 
debian
+opts=pasv ftp://ftp.sendmail.org/pub/sendmail/sendmail\.(\S*)\.tar\.gz debian 
+opts=pasv ftp://ftp.sendmail.org/pub/sendmail/sendmail\.(\S*)\.tar\.gz\.sig 
debian






-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to