Vincent Lefevre wrote:

> tags 635849 patch
> thanks
> 
> On 2011-07-29 23:22:24 +0900, Osamu Aoki wrote:
> > Can any of you who seems to know bettwer on this subject propse good
> > solution while keeping major part of this feature.  Other wise we get
> > bug report for breaking backward comparibility without good reason. 
> 
> I think there is a very easy solution concerning this bug (there
> may be other bugs, though): do not use the -p tempfile option.
> AFAIK, this option is useless (it might be used to retrieve the
> temporary file more easily, but this isn't important).
> 
> Proposed patch:
> 
> --- /usr/bin/xpdf     2011-07-28 06:29:44.000000000 +0200
> +++ xpdf      2011-07-29 16:36:38.000000000 +0200
> @@ -78,7 +78,7 @@
>  elif [ "$cat" = "cat" ]; then
>      $cmd -title "$title" "$file" $pages
>  else
> -    tmp=$(tempfile -p "$(basename "$file")" -s .pdf)
> +    tmp=$(tempfile -s .pdf)
>      $cat "$file" > "$tmp"
>      trap "rm -f \"$tmp\"" EXIT HUP INT QUIT TERM 
>      $cmd -title "$title" "$tmp" $pages || true

Yes, using the original file name to as part of the tempfile name is a
no no, and I really should know better (we all make mistakes...). Thanks
for noticing the core of the problem.  I'll fix it right away.

Best wishes,
Mike



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to