Package: backupninja
Version: 0.9.8.1-1
Severity: normal
Hi!
I have configured backupninja to do a rsync (pull) backup for some host.
However, after the first backup on day 1 (creating daily.1),
it only rotates once on day 2 (creating daily.2) and then backupninja stops
rotating and starts backuping over daily.1 repeatedly.
Debug: skipping rotation of <backuproot>/target.rsync///daily.2 because it
was created 0 days ago (1 needed).
Debug: skipping rotation of <backuproot>/target.rsync///daily.1 because
<backuproot>/target.rsync///daily.2 already exists.
[..]
Warning: <backuproot>/target.rsync///daily.1 already exists. Overwriting
contents.
The fact is, that daily.2 was created not 0 but 2 days ago, according to
stat and also the contents of <backuproot>/metadata/daily.2/rotated.
Correct me if I am wrong, but I think the rsync handler incorrecly inspects
the metadata. Consider line 402..410 of /usr/share/backupninja/rsync:
for (( i=$oldest; i > 0; i-- )); do
if [ -d $dir.$i ]; then
if [ -f $metadata/created ]; then
created=`tail -1 $metadata/created`
elif [ -f $metadata/rotated ]; then
created=`tail -1 $metadata/rotated`
else
created=0
fi
In this loop, the handler tries to find out which archives should be rotated.
However, the metadata variable is always fixed (earlier) to
<backuproot>/metadata/daily.1. IMO this makes no sense and probably should
be set to $backuproot/metadata/$dir.$i if it exists.
Kind regards,
Paul
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
