Package: nagios3
Version: 3.4.1-2
Severity: serious
Tags: patch

Dear Maintainer,

Andreas Beckmann <[email protected]> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.

Lintian detects the problem and warns as follow:

/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.

Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
details.

Severity: serious, Certainty: possible
Check: files, Type: binary, udeb

which is why I am reporting this bug with severity serious (and there fore,
release critical).

Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.

Cheers,

Thomas Goirand (zigo)
diff -u nagios3-3.4.1/debian/nagios3-common.nagios3.init nagios3-3.4.1/debian/nagios3-common.nagios3.init
--- nagios3-3.4.1/debian/nagios3-common.nagios3.init
+++ nagios3-3.4.1/debian/nagios3-common.nagios3.init
@@ -133,6 +133,7 @@
   DIRECTORY=$(dirname $THEPIDFILE)
   [ ! -d $DIRECTORY ] && mkdir -p $DIRECTORY
   chown nagios:nagios $DIRECTORY
+  chmod 0750 /var/run/nagios3
 
   if ! check_started; then
     if ! check_named_pipe; then
diff -u nagios3-3.4.1/debian/changelog nagios3-3.4.1/debian/changelog
--- nagios3-3.4.1/debian/changelog
+++ nagios3-3.4.1/debian/changelog
@@ -1,3 +1,10 @@
+nagios3 (3.4.1-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fixed handling of /var/run/nagios3 life cycle (Closes: #XXXXXX).
+
+ -- Thomas Goirand <[email protected]>  Sat, 06 Oct 2012 22:34:18 +0800
+
 nagios3 (3.4.1-2) unstable; urgency=low
 
   * [265c38d] Don't call the updatecheck on debian
diff -u nagios3-3.4.1/debian/nagios3-cgi.dirs nagios3-3.4.1/debian/nagios3-cgi.dirs
--- nagios3-3.4.1/debian/nagios3-cgi.dirs
+++ nagios3-3.4.1/debian/nagios3-cgi.dirs
@@ -4 +3,0 @@
-var/run/nagios3
diff -u nagios3-3.4.1/debian/nagios3-common.postinst nagios3-3.4.1/debian/nagios3-common.postinst
--- nagios3-3.4.1/debian/nagios3-common.postinst
+++ nagios3-3.4.1/debian/nagios3-common.postinst
@@ -40,7 +40,6 @@
         setperm root nagios 0640 $en/resource.cfg
         setperm nagios adm 2751 /var/log/nagios3
         setperm nagios adm 2751 /var/log/nagios3/archives
-        setperm nagios nagios 0750 /var/run/nagios3
         setperm nagios nagios 0750 /var/lib/nagios3
 	setperm nagios nagios 0750 /var/lib/nagios3/spool
 	setperm nagios nagios 0750 /var/lib/nagios3/spool/checkresults
diff -u nagios3-3.4.1/debian/nagios3-common.lintian-overrides nagios3-3.4.1/debian/nagios3-common.lintian-overrides
--- nagios3-3.4.1/debian/nagios3-common.lintian-overrides
+++ nagios3-3.4.1/debian/nagios3-common.lintian-overrides
@@ -2 +1,0 @@
-dir-or-file-in-var-run var/run/nagios3/
diff -u nagios3-3.4.1/debian/nagios3-common.dirs nagios3-3.4.1/debian/nagios3-common.dirs
--- nagios3-3.4.1/debian/nagios3-common.dirs
+++ nagios3-3.4.1/debian/nagios3-common.dirs
@@ -7,5 +7,4 @@
 var/lib/nagios3/spool/checkresults
 var/log/nagios3/archives
-var/run/nagios3
 var/cache/nagios3
 usr/share/nagios3/debian

Reply via email to