Package: samhain
Version: 2.8.3a-1
Severity: serious
Tags: patch

Dear Maintainer,

Andreas Beckmann <[email protected]> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.

Lintian detects the problem and warns as follow:

/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.

Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
details.

Severity: serious, Certainty: possible
Check: files, Type: binary, udeb

which is why I am reporting this bug with severity serious (and there fore,
release critical).

Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.

Cheers,

Thomas Goirand (zigo)
diff -u samhain-2.8.3a/debian/rules samhain-2.8.3a/debian/rules
--- samhain-2.8.3a/debian/rules
+++ samhain-2.8.3a/debian/rules
@@ -100,6 +100,7 @@
 	dh_installchangelogs docs/Changelog
 	dh_link
 	dh_strip
+	rm -rf `pwd`/debian/samhain/var/run/samhain
 	dh_compress
 	dh_fixperms
 	dh_installdeb
diff -u samhain-2.8.3a/debian/postrm samhain-2.8.3a/debian/postrm
--- samhain-2.8.3a/debian/postrm
+++ samhain-2.8.3a/debian/postrm
@@ -7,7 +7,7 @@
 
 case "$1" in
 	purge)
-		for dir in /var/log/samhain/supervise /var/log/samhain /var/state/samhain
+		for dir in /var/log/samhain/supervise /var/log/samhain /var/state/samhain /var/run/samhain
 		do
 			[ -d "$dir" ] &&  {
 			 	find $dir -type f -exec rm -f {} \;
diff -u samhain-2.8.3a/debian/changelog samhain-2.8.3a/debian/changelog
--- samhain-2.8.3a/debian/changelog
+++ samhain-2.8.3a/debian/changelog
@@ -1,3 +1,10 @@
+samhain (2.8.3a-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fixes /var/run/samhain life cycle handling (Closes: #XXXXXX).
+
+ -- Thomas Goirand <[email protected]>  Sun, 07 Oct 2012 14:26:22 +0000
+
 samhain (2.8.3a-1) unstable; urgency=low
 
   * New upstream release (Closes: #602678)

Reply via email to