Alrighty, patch applied & pbuilder's clean. Now just waiting on Alessandro to review my changes & push the package. On master here if you want to try things out in the interim: git://anonscm.debian.org/collab-maint/hiredis.git
Daniel, I also added support for DEB_BUILD_OPTS=nocheck since it caused you additional grief. Tobi, I haven't bothered addressing the pid file etc. in /tmp just yet, but I'll take a look at that sometime soon. On Sat, Nov 22, 2014 at 1:58 PM, Daniel Schepler <dschep...@gmail.com> wrote: > Source: hiredis > Version: 0.11.0-4 > Severity: serious > > From my pbuilder build log (on amd64): > > echo \ > "daemonize yes\n" \ > "pidfile /tmp/hiredis-test-redis.pid\n" \ > "port 56379\n" \ > "bind 127.0.0.1\n" \ > "unixsocket /tmp/hiredis-test-redis.sock" \ > | redis-server - > ./hiredis-test -h 127.0.0.1 -p 56379 -s /tmp/hiredis-test-redis.sock || \ > ( kill `cat /tmp/hiredis-test-redis.pid` && false ) > #01 Format command without interpolation: PASSED > #02 Format command with %s string interpolation: PASSED > #03 Format command with %s and an empty string: PASSED > #04 Format command with an empty string in between proper interpolations: > PASSED > #05 Format command with %b string interpolation: PASSED > #06 Format command with %b and an empty string: PASSED > #07 Format command with literal %: PASSED > #08 Format command with printf-delegation (int): PASSED > #09 Format command with printf-delegation (char): PASSED > #10 Format command with printf-delegation (short): PASSED > #11 Format command with printf-delegation (long): PASSED > #12 Format command with printf-delegation (long long): PASSED > #13 Format command with printf-delegation (unsigned int): PASSED > #14 Format command with printf-delegation (unsigned char): PASSED > #15 Format command with printf-delegation (unsigned short): PASSED > #16 Format command with printf-delegation (unsigned long): PASSED > #17 Format command with printf-delegation (unsigned long long): PASSED > #18 Format command with printf-delegation (float): PASSED > #19 Format command with printf-delegation (double): PASSED > #20 Format command with invalid printf format: PASSED > #21 Format command by passing argc/argv without lengths: PASSED > #22 Format command by passing argc/argv with lengths: PASSED > #23 Error handling in reply parser: PASSED > #24 Memory cleanup in reply parser: PASSED > #25 Set error on nested multi bulks with depth > 7: PASSED > #26 Works with NULL functions for reply: PASSED > #27 Works when a single newline (\r\n) covers two calls to feed: PASSED > #28 Don't reset state after protocol error: PASSED > #29 Don't do empty allocation for empty multi bulk: PASSED > #30 Returns error when host cannot be resolved: FAILED > #31 Returns error when the unix socket path doesn't accept connections: > PASSED > > Testing against TCP connection (127.0.0.1:56379): > #32 Is able to deliver commands: PASSED > #33 Is a able to send commands verbatim: PASSED > #34 %s String interpolation works: PASSED > #35 %b String interpolation works: PASSED > #36 Binary reply length is correct: PASSED > #37 Can parse nil replies: PASSED > #38 Can parse integer replies: PASSED > #39 Can parse multi bulk replies: PASSED > #40 Can handle nested multi bulk replies: PASSED > #41 Returns I/O error when the connection is lost: PASSED > #42 Returns I/O error on socket timeout: PASSED > #43 Throughput: > (1000x PING: 0.016s) > (1000x LRANGE with 500 elements: 0.105s) > (10000x PING (pipelined): 0.007s) > (10000x LRANGE with 500 elements (pipelined): 1.162s) > > Testing against Unix socket connection (/tmp/hiredis-test-redis.sock): > #44 Is able to deliver commands: PASSED > #45 Is a able to send commands verbatim: PASSED > #46 %s String interpolation works: PASSED > #47 %b String interpolation works: PASSED > #48 Binary reply length is correct: PASSED > #49 Can parse nil replies: PASSED > #50 Can parse integer replies: PASSED > #51 Can parse multi bulk replies: PASSED > #52 Can handle nested multi bulk replies: PASSED > #53 Returns I/O error when the connection is lost: PASSED > #54 Returns I/O error on socket timeout: PASSED > #55 Throughput: > (1000x PING: 0.010s) > (1000x LRANGE with 500 elements: 0.097s) > (10000x PING (pipelined): 0.007s) > (10000x LRANGE with 500 elements (pipelined): 1.189s) > *** 1 TESTS FAILED *** > Makefile:86: recipe for target 'check' failed > make[2]: *** [check] Error 1 > make[2]: Leaving directory '/tmp/buildd/hiredis-0.11.0' > debian/rules:30: recipe for target 'override_dh_auto_test' failed > make[1]: *** [override_dh_auto_test] Error 2 > make[1]: Leaving directory '/tmp/buildd/hiredis-0.11.0' > debian/rules:13: recipe for target 'build' failed > make: *** [build] Error 2 > dpkg-buildpackage: error: debian/rules build gave error exit status 2 > E: Failed autobuilding of package > > This is with the default pbuilder configuration which disables network > access > for the build. However, I've also reproduced it with USENETWORK=yes, which > just makes the test take much longer to fail. > > It would also seem that the source package doesn't honor > DEB_BUILD_OPTIONS=nocheck, which makes it difficult to disable the tests > to get > a package built despite the test failures. > -- > Daniel Schepler > -- *Tom Lee */ http://tomlee.co / @tglee <http://twitter.com/tglee>
