Alrighty, talking this over with Alessandro he made the case that we should keep tests that don't rely on *external *network connections. See e.g. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753944 which makes the case for a loopback interface in pbuilder.
Tobi, to that effect I modified your patch to keep the tests that work fine with localhost & thus pass in pbuilder. Also, I feel like the "serious" severity is overstating the issue given that 0.11.0-4 builds fine in buildd/sbuild. Alessandro pointed out the periodic rebuilds would have revealed this issue otherwise. If there are no objections I'd like to propose we adjust the severity of this bug to "normal" & leave the fix for this particular bug until after the Jessie freeze. Otherwise, I can reach out to the release team to get the hiredis package unblocked & work through getting a new package uploaded with the pbuilder fixes & nocheck support. On Mon, Nov 24, 2014 at 4:32 AM, Tobias Frost <t...@frost.de> wrote: > On Mon, 24 Nov 2014 00:45:04 -0800 Tom Lee <deb...@tomlee.co> wrote: > > Alrighty, patch applied & pbuilder's clean. Now just waiting on > Alessandro > > to review my changes & push the package. On master here if you want to > try > > things out in the interim: git:// > anonscm.debian.org/collab-maint/hiredis.git > > > > > > Daniel, I also added support for DEB_BUILD_OPTS=nocheck since it caused > you > > additional grief. > > > > Tobi, I haven't bothered addressing the pid file etc. in /tmp just yet, > but > > I'll take a look at that sometime soon. > > Please remember we are in freeze: Both those changes are not covered by the > freeze policy as they are not targeting RC bugs. > As the DEB_BUILD_OPTIONS=nocheck is already committed, I suggest you ask on > #debian-release if that they could accept this. > > The /tmp thing is unimportant now, and can be fixed for Stretch, (if you > want > to fix it) > > -- > tobi > > -- *Tom Lee */ http://tomlee.co / @tglee <http://twitter.com/tglee>
